[PATCH] D28228: [clang-move] Support moving enum declarations.

Haojian Wu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jan 3 06:15:20 PST 2017


hokein added a comment.

In https://reviews.llvm.org/D28228#633930, @ioeric wrote:

> I mean, if a enum helper used in say only old cc, will it be moved? The question is related to https://reviews.llvm.org/D27673. You don't need to support enum helper now, but it would be nice to drop a comment somewhere.


Done. Add a comment about this. Enum helpers will not moved whether they are used or not.



================
Comment at: clang-move/ClangMove.h:140
+  /// old.h/cc.
+  void addMovedAndDeletedDecl(const NamedDecl *Decl);
+
----------------
ioeric wrote:
> Maybe just `addMovedDecl`? `move` indicates move and delete IMO. But you might need to explain what's really going on in the comment.
Instead of making an interface in the class, I put this function as a helper function in .cc, and named it as `MoveDeclFromOldFileToNewFile`. Hope this will make it clearer.


https://reviews.llvm.org/D28228





More information about the cfe-commits mailing list