[PATCH] D28228: [clang-move] Support moving enum declarations.

Haojian Wu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jan 3 05:20:49 PST 2017


hokein added a comment.

In https://reviews.llvm.org/D28228#633863, @ioeric wrote:

> Do we consider enum helpers?


This patch excludes enum helpers, only considers the enum declarations which are defined in old.h. 
Ideally, we should support enum helpers which are defined in old.cc, but that's another topic.



================
Comment at: clang-move/ClangMove.cpp:171
+    assert(ED);
+    MoveTool->getMovedDecls().push_back(ED);
+    MoveTool->getUnremovedDeclsInOldHeader().erase(ED);
----------------
ioeric wrote:
> These 3 lines seen to be repeated. Maybe pull them out as a `MoveTool` method?
Done. I made a function for these repeated lines, but it seems hard to figure out a pretty name for it.


https://reviews.llvm.org/D28228





More information about the cfe-commits mailing list