[PATCH] D26830: [libcxx] Add string_view literals

Eric Fiselier via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jan 3 03:19:47 PST 2017


EricWF added a comment.

This LGTM. I'll approve once I see the inline comments addressed.



================
Comment at: test/std/strings/string.view/string.view.literals/literal.pass.cpp:10
+//===----------------------------------------------------------------------===//
+
+// UNSUPPORTED: c++98, c++03, c++11, c++14
----------------
This needs a `// XFAIL: clang-3, gcc-4, apple-clang-7, apple-clang-8`


https://reviews.llvm.org/D26830





More information about the cfe-commits mailing list