[PATCH] D28223: clean up use of _WIN32

Kim Gräsman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jan 3 01:29:26 PST 2017


kimgr added a comment.

I don't think wchar_t is UCS-2 anymore, I read somewhere that they switched to UTF-16 as of Windows 2000.

Is it the actual encoding you're interested in, or the element size? Judging from the diff, it looks like both, but the code appears to assume UCS-2, so it could already be broken.

Maybe you could phrase it as `_LIBCPP_16BIT_WCHAR` or `_LIBCPP_SHORT_WCHAR` instead?


Repository:
  rL LLVM

https://reviews.llvm.org/D28223





More information about the cfe-commits mailing list