[PATCH] D28220: provide Win32 native threading

[Saleem Abdulrasool via Phabricator via cfe-commits]

compnerd added inline comments.


================
Comment at: include/__threading_support:46
+inline _LIBCPP_INLINE_VISIBILITY
+int __libcpp_recursive_mutex_init(__libcpp_mutex_t *__m);
+
----------------
EricWF wrote:
> The forward declarations of the `__libcpp_` threading wrapper should be shared between all API's. Please don't add your own forward declarations for Windows. 
Yeah, restructed that.  There is now the dependent patch for the type-erased mutex handling.


================
Comment at: include/__threading_support:44
+#define WIN32_LEAN_AND_MEAN
+#define VC_EXTRA_LEAN
+#include <Windows.h>
----------------
EricWF wrote:
> Do these definitions have any affect when `<Windows.h>` has already been included?
> Also are these definitions required before including the header, or merely beneficial? If they are required this will make the `<Windows.h>` header a pain to use with modules.
> 
> 
No, they dont effect it once it has been included.  They are beneficial since they reduce the amount of stuff that gets included (including things which, at least when I last checked, can cause clang to choke).


Repository:
  rL LLVM

https://reviews.llvm.org/D28220