[PATCH] D28166: Properly merge K&R functions that have attributes

Richard Smith via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Jan 2 18:02:55 PST 2017


rsmith added a comment.

In https://reviews.llvm.org/D28166#633621, @aaron.ballman wrote:

> Do you think this patch should be gated on (or perhaps combined with) a fix for the lowering bug, or do you think this patch is reasonable on its own? Given that it turns working code into UB, I think my preference is to gate it on a fix for the lowering bug, but I'm also not certain I am the right person to implement that fix (though I could give it a shot).


The test in question has a comment pointing to PR7117, which in turn indicates that we might miscompile parts of FreeBSD if we land this as-is. So I think we need to gate this on a fix for the lowering bug.


https://reviews.llvm.org/D28166





More information about the cfe-commits mailing list