[PATCH] D28220: provide Win32 native threading

Saleem Abdulrasool via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Jan 2 17:29:24 PST 2017


compnerd marked 3 inline comments as done.
compnerd added a comment.

The SRW initializers avoid the initializer changes, so its one less set of changes that is necessary.



================
Comment at: include/__threading_support:33
 #include <__external_threading>
+#elif defined(_WIN32) && defined(_LIBCPP_HAS_THREAD_API_WIN32)
+#define WIN32_LEAN_AND_MEAN
----------------
EricWF wrote:
> Isn't checking `_LIBCPP_HAS_THREAD_API_WIN32` enough?
No, because the structure of the header is such that it requires redeclarations :-(.


Repository:
  rL LLVM

https://reviews.llvm.org/D28220





More information about the cfe-commits mailing list