[PATCH] D28148: [Sema] Suppress warnings for C's zero initializer

Richard Smith via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Jan 2 13:01:11 PST 2017


rsmith added a comment.

Looks good to go once Daniel's and my comments are addressed. Thank you.



================
Comment at: lib/AST/Expr.cpp:1887
+bool InitListExpr::isIdiomaticZeroInitializer(const LangOptions &LangOpts) const {
+  assert(!getSyntacticForm() && "only test syntactic form as zero initializer");
+
----------------
`!isSyntacticForm()` would be preferable here instead of `!getSyntacticForm()`.


https://reviews.llvm.org/D28148





More information about the cfe-commits mailing list