[PATCH] D21298: [Clang-tidy] delete null check

[Alexander Kornienko via Phabricator via cfe-commits]

alexfh added a comment.

One more late comment (I should really add a check-list for new checks): this check lacks tests with macros and templates with multiple instantiations.

Incorrect handling of templates will likely not manifest in the current state of the check, it's brittle, since it relies on the error deduplication performed by clang-tidy and it can break easily (e.g. if message text will depend on the instantiation or if something changes in the way clang-tidy deduplicates messages). However, attempts to apply fixes to code resulting from macro expansions is unlikely to result in compilable code.


Repository:
  rL LLVM

https://reviews.llvm.org/D21298