[PATCH] D28212: typeinfo: provide a partial implementation for Win32

[David Majnemer via Phabricator via cfe-commits]

majnemer added inline comments.


================
Comment at: src/typeinfo.cpp:28-29
+#if defined(_WIN64)
+  static constexpr const size_t fnv_offset_basis = 14695981039346656037;
+  static constexpr const size_t fnv_prime = 10995116282110;
+#else
----------------
majnemer wrote:
> Why make these static? Seems strange to use that storage duration.
These literals are ill-formed, I think you need a ULL suffix here.


================
Comment at: src/typeinfo.cpp:28-32
+  static constexpr const size_t fnv_offset_basis = 14695981039346656037;
+  static constexpr const size_t fnv_prime = 10995116282110;
+#else
+  static constexpr const size_t fnv_offset_basis = 2166136261;
+  static constexpr const size_t fnv_prime = 16777619;
----------------
Why make these static? Seems strange to use that storage duration.


Repository:
  rL LLVM

https://reviews.llvm.org/D28212