[PATCH] D26830: [libcxx] Add string_view literals

[Eric Fiselier via Phabricator via cfe-commits]

EricWF added a comment.

Alright. I committed the Clang changes. Just re-building now so I can test this.



================
Comment at: include/string_view:780
+} // namespace literals
+#endif
+
----------------
`// _LIBCPP_STD_VER > 14` comment please.


================
Comment at: test/std/strings/string.view/string.view.literals/literal1.pass.cpp:16
+
+int main()
+{
----------------
What's the point of this test that `literal.pass.cpp` doesn't cover?


================
Comment at: test/std/strings/string.view/string.view.literals/literal2.pass.cpp:16
+
+int main()
+{
----------------
What's the point of this test that `literal.pass.cpp` doesn't cover?


https://reviews.llvm.org/D26830