[PATCH] D28153: [clang] Fix clean build of generate-order-file

[Alexander Shaposhnikov via Phabricator via cfe-commits]

alexshap added inline comments.


================
Comment at: CMakeLists.txt:436
+
+  if(CLANG_ORDER_FILE AND NOT EXISTS ${CLANG_ORDER_FILE})
+    string(FIND "${CLANG_ORDER_FILE}" "${CMAKE_CURRENT_BINARY_DIR}" PATH_START)
----------------
mehdi_amini wrote:
> So why `if(CLANG_ORDER_FILE ` here? 
i don't know why originally it was this way, 
if my understanding is correct - 
you are right - if(CLANG_ORDER_FILE  is not necessary here -
this condition should be replaced just with if(NOT EXISTS ${CLANG_ORDER_FILE})
so yea, i can update this as well.
In the first version of this patch i moved this entire block "as is" without changes.
(this resolved the issue with the empty CLANG_ORDER_FILE in utils/perf-training/CMakeLists.txt).


Repository:
  rL LLVM

https://reviews.llvm.org/D28153