[PATCH] D28153: [clang] Fix clean build of generate-order-file

[Alexander Shaposhnikov via Phabricator via cfe-commits]

alexshap added inline comments.


================
Comment at: utils/perf-training/CMakeLists.txt:61
+    message(FATAL_ERROR "Output clang order file is not set")
+  endif()
+
----------------
mehdi_amini wrote:
> I'm missing something: the code in the main CMakeLists seems to allows to have an empty value for the CLANG_ORDER_FILE?
if i understand correctly: CMakeLists.txt: lines 424 - 433:
if(CLANG_ORDER_FILE STREQUAL "")
    unset(CLANG_ORDER_FILE CACHE)
    unset(CLANG_ORDER_FILE)
  endif()

set(CLANG_ORDER_FILE ${CMAKE_CURRENT_BINARY_DIR}/clang.order CACHE FILEPATH

but the file (CLANG_ORDER_FILE) itself can be empty, not the variable. If CLANG_ORDER_FILE is empty that command line won't be correct



Repository:
  rL LLVM

https://reviews.llvm.org/D28153