[PATCH] D21298: [Clang-tidy] delete null check
Alexander Kornienko via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu Dec 29 08:56:10 PST 2016
alexfh added a comment.
In https://reviews.llvm.org/D21298#632235, @aaron.ballman wrote:
> In https://reviews.llvm.org/D21298#632154, @xazax.hun wrote:
>
> > Small ping, is this ready to be committed?
>
>
> If @alexfh doesn't sign off by tomorrow, I think it's fine to commit. We can deal with any last minute comments post-commit.
Yup, that's totally fine, especially when there was a thorough pre-commit code review.
https://reviews.llvm.org/D21298
More information about the cfe-commits
mailing list