[libcxx] r290503 - [libc++] Make __num_get_float hidden

Shoaib Meenai via cfe-commits cfe-commits at lists.llvm.org
Sat Dec 24 10:05:32 PST 2016


Author: smeenai
Date: Sat Dec 24 12:05:32 2016
New Revision: 290503

URL: http://llvm.org/viewvc/llvm-project?rev=290503&view=rev
Log:
[libc++] Make __num_get_float hidden

It's an internal function and shouldn't be exported. It's also a source
of discrepancy in the published ABI list; these symbols aren't exported
for me on CentOS 7 or Ubuntu 16.04, leading to spurious check-cxx-abilist
failures.

Differential Revision: https://reviews.llvm.org/D27153

Modified:
    libcxx/trunk/include/locale
    libcxx/trunk/lib/abi/x86_64-unknown-linux-gnu.abilist

Modified: libcxx/trunk/include/locale
URL: http://llvm.org/viewvc/llvm-project/libcxx/trunk/include/locale?rev=290503&r1=290502&r2=290503&view=diff
==============================================================================
--- libcxx/trunk/include/locale (original)
+++ libcxx/trunk/include/locale Sat Dec 24 12:05:32 2016
@@ -779,6 +779,7 @@ long double __do_strtod<long double>(con
 }
 
 template <class _Tp>
+_LIBCPP_HIDDEN
 _Tp
 __num_get_float(const char* __a, const char* __a_end, ios_base::iostate& __err)
 {

Modified: libcxx/trunk/lib/abi/x86_64-unknown-linux-gnu.abilist
URL: http://llvm.org/viewvc/llvm-project/libcxx/trunk/lib/abi/x86_64-unknown-linux-gnu.abilist?rev=290503&r1=290502&r2=290503&view=diff
==============================================================================
--- libcxx/trunk/lib/abi/x86_64-unknown-linux-gnu.abilist (original)
+++ libcxx/trunk/lib/abi/x86_64-unknown-linux-gnu.abilist Sat Dec 24 12:05:32 2016
@@ -937,9 +937,6 @@
 {'is_defined': True, 'type': 'FUNC', 'name': '_ZNSt3__114error_categoryD1Ev'}
 {'is_defined': True, 'type': 'FUNC', 'name': '_ZNSt3__114error_categoryD2Ev'}
 {'is_defined': True, 'type': 'FUNC', 'name': '_ZNSt3__115__get_classnameEPKcb'}
-{'is_defined': True, 'type': 'FUNC', 'name': '_ZNSt3__115__num_get_floatIdEET_PKcS3_Rj'}
-{'is_defined': True, 'type': 'FUNC', 'name': '_ZNSt3__115__num_get_floatIeEET_PKcS3_Rj'}
-{'is_defined': True, 'type': 'FUNC', 'name': '_ZNSt3__115__num_get_floatIfEET_PKcS3_Rj'}
 {'is_defined': True, 'type': 'FUNC', 'name': '_ZNSt3__115__thread_struct25notify_all_at_thread_exitEPNS_18condition_variableEPNS_5mutexE'}
 {'is_defined': True, 'type': 'FUNC', 'name': '_ZNSt3__115__thread_struct27__make_ready_at_thread_exitEPNS_17__assoc_sub_stateE'}
 {'is_defined': True, 'type': 'FUNC', 'name': '_ZNSt3__115__thread_structC1Ev'}




More information about the cfe-commits mailing list