[libcxx] r290480 - Fix sign-compare warnings on ARM platforms caused by wchar_t being unsigned

Eric Fiselier via cfe-commits cfe-commits at lists.llvm.org
Fri Dec 23 19:09:00 PST 2016


Author: ericwf
Date: Fri Dec 23 21:09:00 2016
New Revision: 290480

URL: http://llvm.org/viewvc/llvm-project?rev=290480&view=rev
Log:
Fix sign-compare warnings on ARM platforms caused by wchar_t being unsigned

Modified:
    libcxx/trunk/test/std/re/re.traits/value.pass.cpp

Modified: libcxx/trunk/test/std/re/re.traits/value.pass.cpp
URL: http://llvm.org/viewvc/llvm-project/libcxx/trunk/test/std/re/re.traits/value.pass.cpp?rev=290480&r1=290479&r2=290480&view=diff
==============================================================================
--- libcxx/trunk/test/std/re/re.traits/value.pass.cpp (original)
+++ libcxx/trunk/test/std/re/re.traits/value.pass.cpp Fri Dec 23 21:09:00 2016
@@ -82,15 +82,15 @@ int main()
         }
         for (wchar_t c = '0'; c < '8'; ++c)
         {
-            assert(t.value(c, 8) == c - '0');
-            assert(t.value(c, 10) == c - '0');
-            assert(t.value(c, 16) == c - '0');
+            assert(t.value(c, 8) ==  static_cast<int>(c - '0'));
+            assert(t.value(c, 10) == static_cast<int>(c - '0'));
+            assert(t.value(c, 16) == static_cast<int>(c - '0'));
         }
         for (wchar_t c = '8'; c < ':'; ++c)
         {
             assert(t.value(c, 8) == -1);
-            assert(t.value(c, 10) == c - '0');
-            assert(t.value(c, 16) == c - '0');
+            assert(t.value(c, 10) == static_cast<int>(c - '0'));
+            assert(t.value(c, 16) == static_cast<int>(c - '0'));
         }
         for (wchar_t c = ':'; c < 'A'; ++c)
         {
@@ -102,7 +102,7 @@ int main()
         {
             assert(t.value(c, 8) == -1);
             assert(t.value(c, 10) == -1);
-            assert(t.value(c, 16) == c - 'A' +10);
+            assert(t.value(c, 16) == static_cast<int>(c - 'A' +10));
         }
         for (wchar_t c = 'G'; c < 'a'; ++c)
         {
@@ -114,7 +114,7 @@ int main()
         {
             assert(t.value(c, 8) == -1);
             assert(t.value(c, 10) == -1);
-            assert(t.value(c, 16) == c - 'a' +10);
+            assert(t.value(c, 16) == static_cast<int>(c - 'a' +10));
         }
         for (wchar_t c = 'g'; c < 0xFFFF; ++c)
         {




More information about the cfe-commits mailing list