[PATCH] D28080: [Docs][OpenCL] Added OpenCL feature description to user manual.
Mats Petersson via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Fri Dec 23 13:47:39 PST 2016
Leporacanthicus added inline comments.
================
Comment at: docs/UsersManual.rst:2083
+space is represented by the absence of an address space attribute in the IR (see
+also :ref:`the section on address space attribute <opencl_adrsp>`).
+
----------------
Should this be `opencl_addrsp` (two d's)?
================
Comment at: docs/UsersManual.rst:2242
+
+ my_sub_group_shuffle() __attribute((convergent));
+
----------------
Shouldn't that be `__attribute__`?
================
Comment at: docs/UsersManual.rst:2259
+
+ for (int i=0; i<3; i++)
+ my_sub_group_shuffle()
----------------
Compared to the unrolled code below, this should probably say `i < 4` rather than `i < 3`?
================
Comment at: docs/UsersManual.rst:2278
+
+.. _opencl_adrsp:
+
----------------
Obviously, change this as well to `opencl_addrsp`...
https://reviews.llvm.org/D28080
More information about the cfe-commits
mailing list