[PATCH] D27898: [compiler-rt] [builtins] Implement __floattitf() & __floatuntitf()

[Renato Golin via Phabricator via cfe-commits]

rengolin added inline comments.


================
Comment at: lib/builtins/floatuntitf.c:73
+    long_double_bits fb;
+    fb.u.high.all = (du_int)(e + 16383) << 48            /* exponent */
+                  | ((a >> 64) & 0x0000ffffffffffffLL);  /* mantissa */
----------------
rengolin wrote:
> mgorny wrote:
> > rengolin wrote:
> > > nit: an hexadecimal pattern here would be clearer. same above.
> > Do you mean something like: `(foo << 48) & 0xffff....`?
> No, just the `16383` to `0x3FFF`
Though, now I think your proposal may be better. :)

Whatever works, I'm not too concerned about that.


https://reviews.llvm.org/D27898