[PATCH] D27898: [compiler-rt] [builtins] Implement __floattitf() & __floatuntitf()

[Renato Golin via Phabricator via cfe-commits]

rengolin accepted this revision.
rengolin added a comment.
This revision is now accepted and ready to land.

My floating-point-fu is lacking, so I'll trust you guys that this makes sense. :)

I didn't see anything egregious, so LGTM with the nit inline.

cheers,
--renato



================
Comment at: lib/builtins/floatuntitf.c:73
+    long_double_bits fb;
+    fb.u.high.all = (du_int)(e + 16383) << 48            /* exponent */
+                  | ((a >> 64) & 0x0000ffffffffffffLL);  /* mantissa */
----------------
nit: an hexadecimal pattern here would be clearer. same above.


https://reviews.llvm.org/D27898