[PATCH] D26846: __uuidof() and declspec(uuid("...")) should be allowed on enumeration types

Reid Kleckner via cfe-commits cfe-commits at lists.llvm.org
Wed Dec 21 08:47:28 PST 2016


On Wed, Dec 21, 2016 at 8:36 AM, Aaron Ballman <aaron.ballman at gmail.com>
wrote:

> That change appears to have been lost, and I would like to see them
> brought back. I think they may have gotten lost during the rebase, as
> they were present in https://reviews.llvm.org/D26846?id=78569.
>

I removed the tablegen logic because it was dead after changing the uuid
SubjectList to this:
  let Subjects = SubjectList<[Record, Enum], WarnDiag,
"ExpectedEnumOrClass">;

It was necessary to go from CXXRecord to Record here so that we would
accept __uuid on structs in C and then reject the attribute as being
C++-only later.

Feel free to add the case back. From my reading of the code, it seems
like CalculateDiagnostic isn't intended to cover every case.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20161221/d2b74e7d/attachment.html>


More information about the cfe-commits mailing list