[PATCH] D27773: [analyzer] Add checker modeling gtest APIs.

Aleksei Sidorin via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Dec 21 07:39:09 PST 2016


a.sidorin added a comment.

Looks good for me, but I'm not a reviewer. Thank you Devin!



================
Comment at: test/Driver/analyzer-target-enabled-checkers.cpp:7
 // CHECK-DARWIN: "-analyzer-checker=core"
+// CHECK-DARWIN-SAME: "-analyzer-checker=apiModeling"
 // CHECK-DARWIN-SAME: "-analyzer-checker=unix"
----------------
A very minor nit/question.
Do we have any convention on checker naming? Most checkers are starting with capital letters, but some not. As "API" is an abbreviation, I think we should at least start it with capital.


https://reviews.llvm.org/D27773





More information about the cfe-commits mailing list