[PATCH] D27898: [compiler-rt] [builtins] Implement __floattitf() & __floatuntitf()

[Michał Górny via Phabricator via cfe-commits]

mgorny updated this revision to Diff 82235.
mgorny marked an inline comment as done.
mgorny added a comment.

I think I've shifted all of `{`/`}` to be in line with keywords.

As for the splitting the code, you're probably right. However, I'd rather do that in a separate patch (I'll add it to my TODO, I promise).

I think that most of those files reuse a similar code -- I think it's for the case when the integer has greater range than the float. It would certainly also make sense to try to commonize the code used for signed and unsigned. However, I'm a little worried that it might make the result unreadable.


https://reviews.llvm.org/D27898

Files:
  lib/builtins/CMakeLists.txt
  lib/builtins/floattitf.c
  lib/builtins/floatuntitf.c
  test/builtins/Unit/floattitf_test.c
  test/builtins/Unit/floatuntitf_test.c

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D27898.82235.patch
Type: text/x-patch
Size: 24631 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20161221/a928f2f5/attachment-0001.bin>