[PATCH] D27971: Make FormatStyle.GetStyleOfFile test work on MSVC
Manuel Klimek via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed Dec 21 00:24:02 PST 2016
klimek accepted this revision.
klimek added a comment.
This revision is now accepted and ready to land.
Apart from the error handling LG. Thanks!
================
Comment at: lib/Format/Format.cpp:1920-1922
+ std::error_code EC = FS->makeAbsolute(Path);
+ assert(!EC);
+ (void)EC;
----------------
I think if makeAbsolute doesn't work, we will probably want to err out here:
if (EC) {
llvm::errs() << ... << EC.message << ...
return Style;
}
https://reviews.llvm.org/D27971
More information about the cfe-commits
mailing list