[PATCH] D27852: [modules] Handle modules with nonstandard names in module.private.modulemaps

[Graydon Hoare via Phabricator via cfe-commits]

graydon added inline comments.


================
Comment at: test/Modules/implicit-private-with-different-name.m:13
+// expected-warning at Inputs/implicit-private-with-different-name/A.framework/Modules/module.private.modulemap:1{{top-level module 'APrivate' in private module map, expected a submodule of 'A'}}
+// expected-note at Inputs/implicit-private-with-different-name/A.framework/Modules/module.private.modulemap:1{{make 'APrivate' a submodule of 'A' to ensure it can be found by name}}
+// CHECK: fix-it:"{{.*}}/Inputs/implicit-private-with-different-name/A.framework/Modules/module.private.modulemap":{1:18-1:26}:"A.Private"
----------------
bruno wrote:
> I think we can enhance the usability a bit here, how about:
> 
> warning: top-level module 'APrivate' in private module map, expected a submodule of 'A'
> note: make 'APrivate' a submodule of 'A' to ensure it can be found by name
>   framework module APrivate {
>                    ^
>                 A.Private
> 
> 
I'm not sure what you're requesting; as far as I can see that is exactly the diagnostic I'm emitting (along with the fixit)


https://reviews.llvm.org/D27852