[PATCH] D26750: [clang-tidy] Add modernize-use-default-member-init check

[Malcolm Parsons via Phabricator via cfe-commits]

malcolm.parsons marked 9 inline comments as done.
malcolm.parsons added inline comments.


================
Comment at: clang-tidy/modernize/UseDefaultMemberInitCheck.cpp:77-78
+static bool sameValue(const Expr *E1, const Expr *E2) {
+  E1 = ignoreUnaryPlus(getInitializer(E1->IgnoreImpCasts()));
+  E2 = ignoreUnaryPlus(getInitializer(E2->IgnoreImpCasts()));
+
----------------
aaron.ballman wrote:
> Do you also want to ignore paren expressions?
Maybe. 
Am I reimplementing some existing clang function here?


================
Comment at: clang-tidy/modernize/UseDefaultMemberInitCheck.cpp:123
+
+void UseDefaultMemberInitCheck::registerMatchers(MatchFinder *Finder) {
+  auto Init =
----------------
aaron.ballman wrote:
> This check should not register matchers for C++ < 11.
I always forget to add a condition here; maybe add_new_check.py could remind me.


https://reviews.llvm.org/D26750