[PATCH] D27180: Testbed and skeleton of a new expression parser

[Aleksei Sidorin via Phabricator via cfe-commits]

a.sidorin added a comment.

Sorry for being late :(



================
Comment at: cfe/trunk/tools/clang-import-test/clang-import-test.cpp:99
+    llvm::errs() << LineString << '\n';
+    std::string Space(LocColumn, ' ');
+    llvm::errs() << Space.c_str() << '\n';
----------------
I still think `indent()` method is more evident here and it doesn't require memory allocation.


================
Comment at: cfe/trunk/tools/clang-import-test/clang-import-test.cpp:125
+        if (!Invalid) {
+          llvm::errs() << Ref.str() << '\n';
+        }
----------------
No `str()` is needed here, `raw_ostream` works well even with non null-terminated StringRefs.


================
Comment at: cfe/trunk/tools/clang-import-test/clang-import-test.cpp:303
+  for (auto I : Imports) {
+      llvm::Expected<std::unique_ptr<CompilerInstance>> ImportCI = Parse(I, {});
+      if (auto E = ImportCI.takeError()) {
----------------
Broken indentation.


Repository:
  rL LLVM

https://reviews.llvm.org/D27180