[PATCH] D21298: [Clang-tidy] delete null check
Aaron Ballman via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Mon Dec 19 09:29:44 PST 2016
aaron.ballman accepted this revision.
aaron.ballman added a comment.
LGTM, with one nit. You should wait for @alexfh to sign off before committing though, since he requested changes.
================
Comment at: clang-tidy/readability/DeleteNullPointerCheck.cpp:53
+ "'if' statement is unnecessary; deleting null pointer has no effect");
+ if (IfWithDelete->getElse()) {
+ return;
----------------
Elide the braces.
https://reviews.llvm.org/D21298
More information about the cfe-commits
mailing list