[PATCH] D27673: [clang-move] Only move used helper declarations.

[Eric Liu via Phabricator via cfe-commits]

ioeric added inline comments.


================
Comment at: test/clang-move/move-used-helper-decls.cpp:1
+// RUN: mkdir -p %T/used-helper-decls
+// RUN: cp %S/Inputs/helper_decls_test*  %T/used-helper-decls/
----------------
Can you also add test cases where class members are treated as the same node in the graph?


================
Comment at: test/clang-move/move-used-helper-decls.cpp:9
+
+// CHECK-NEW-CLASS1-CPP: #include "{{.*}}new_helper_decls_test.h"
+// CHECK-NEW-CLASS1-CPP-SAME: {{[[:space:]]}}
----------------
It'd be really helpful if you can provide a brief comment on what you are testing for each test case. 


================
Comment at: test/clang-move/move-used-helper-decls.cpp:202
+
+// CHECK-OLD-FUN2-H-NOT: inline void Fun2() {}
----------------
Maybe also add a test case to move all symbols in the old file.


https://reviews.llvm.org/D27673