[PATCH] D27836: Store the "current position" index within the ASTRecordReader.

Richard Smith via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Dec 16 17:14:42 PST 2016


rsmith added a comment.

I like moving `Idx` into the reader, but I have mixed feelings about the iterator-like interface. For consistency with the rest of the `ASTRecordReader` interface, and with how we model the writer side, I think perhaps `Record.ReadInt()` would fit better than using `*Record++`.


https://reviews.llvm.org/D27836





More information about the cfe-commits mailing list