[PATCH] D27440: clang-format-vsix: fail when clang-format outputs to stderr

Antonio Maiorano via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Dec 16 04:53:30 PST 2016


amaiorano added a comment.

In https://reviews.llvm.org/D27440#624773, @djasper wrote:

> I agree that fallback-style should only be used when there is no .clang-format file. If we find one, and it doesn't parse correctly, we should neither use the fallback style nor scan in higher-level directories (not sure whether we currently do that).


Cool, and do you agree that clang-format should also return non-zero when this happens? If so, I'll just abort this change. Perhaps I'll take a look at fixing this in clang-format as discussed.


https://reviews.llvm.org/D27440





More information about the cfe-commits mailing list