[PATCH] D27700: [clang-tidy] refactor ExprSequence out of misc-use-after-move check

Marek SokoĊ‚owski via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Dec 16 04:00:50 PST 2016


mnbvmar marked 9 inline comments as done.
mnbvmar added inline comments.


================
Comment at: clang-tidy/misc/UseAfterMoveCheck.cpp:18
 using namespace clang::ast_matchers;
+using namespace clang::tidy::utils;
+
----------------
mboehme wrote:
> Prazek wrote:
> > Prazek wrote:
> > > I don't think it is required
> > ok I guess I am wrong
> I would suggest instead adding an explicit "utils::" qualifier -- it's only needed in two places anyway. I don't feel strongly about this though.
It's actually needed in more places (I think at least four). I feel like leaving it here.


https://reviews.llvm.org/D27700





More information about the cfe-commits mailing list