r289919 - Remove "-disable-llvm-optzns -verify" from the RUN line.

Akira Hatanaka via cfe-commits cfe-commits at lists.llvm.org
Thu Dec 15 21:45:01 PST 2016


It looks like it failed again. I’m still looking.

> On Dec 15, 2016, at 9:14 PM, Nico Weber <thakis at chromium.org> wrote:
> 
> I gave this a shot in 289924. Please check that's the right thing.
> 
> On Fri, Dec 16, 2016 at 12:09 AM, Nico Weber <thakis at chromium.org <mailto:thakis at chromium.org>> wrote:
> On Fri, Dec 16, 2016 at 12:08 AM, Nico Weber <thakis at chromium.org <mailto:thakis at chromium.org>> wrote:
> I think the problem was that you didn't pipe the output to /dev/null or -, and so a .ll file got created which now confuses the bots.
> 
> I suggest:
> 1. Add `// RUN: rm -f right_path.ll` at the top for a while (look through magic lit vars to find one that expands to the right thing)
> 
> I think you want `rm -f %S/default-expr-arguments-3.ll`
>  
> 2. If the intent for this is to be a -verify check, add that back
> 3. If not, remove expected-no-diagnostics
> 4. If not, is this a FileCheck test? If so, pipe output to FileCheck, add CHECK lines
> 5. If it isn't FileCheck either, what does this test?
> 
> On Fri, Dec 16, 2016 at 12:05 AM, Nico Weber <thakis at chromium.org <mailto:thakis at chromium.org>> wrote:
> Are you aware that this is still failing on all the bots? (http://lab.llvm.org:8011/builders/clang-atom-d525-fedora-rel/builds/493 <http://lab.llvm.org:8011/builders/clang-atom-d525-fedora-rel/builds/493> eg)
> 
> On Thu, Dec 15, 2016 at 11:18 PM, Akira Hatanaka via cfe-commits <cfe-commits at lists.llvm.org <mailto:cfe-commits at lists.llvm.org>> wrote:
> Author: ahatanak
> Date: Thu Dec 15 22:18:53 2016
> New Revision: 289919
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=289919&view=rev <http://llvm.org/viewvc/llvm-project?rev=289919&view=rev>
> Log:
> Remove "-disable-llvm-optzns -verify" from the RUN line.
> 
> Modified:
>     cfe/trunk/test/SemaTemplate/default-expr-arguments-3.cpp
> 
> Modified: cfe/trunk/test/SemaTemplate/default-expr-arguments-3.cpp
> URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/test/SemaTemplate/default-expr-arguments-3.cpp?rev=289919&r1=289918&r2=289919&view=diff <http://llvm.org/viewvc/llvm-project/cfe/trunk/test/SemaTemplate/default-expr-arguments-3.cpp?rev=289919&r1=289918&r2=289919&view=diff>
> ==============================================================================
> --- cfe/trunk/test/SemaTemplate/default-expr-arguments-3.cpp (original)
> +++ cfe/trunk/test/SemaTemplate/default-expr-arguments-3.cpp Thu Dec 15 22:18:53 2016
> @@ -1,4 +1,4 @@
> -// RUN: %clang_cc1 -std=c++14 -emit-llvm -disable-llvm-optzns -verify %s
> +// RUN: %clang_cc1 -std=c++14 -emit-llvm -o - %s
>  // expected-no-diagnostics
> 
>  namespace PR28795 {
> 
> 
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at lists.llvm.org <mailto:cfe-commits at lists.llvm.org>
> http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits <http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits>
> 
> 
> 
> 

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20161215/db16ac30/attachment.html>


More information about the cfe-commits mailing list