[PATCH] D27801: [change-namespace] handling templated type aliases correctly.

Haojian Wu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Dec 15 02:41:44 PST 2016


hokein accepted this revision.
hokein added a comment.
This revision is now accepted and ready to land.

LGTM.



================
Comment at: change-namespace/ChangeNamespace.cpp:730
+  // Make `FromDecl` the immediate declaration that `Type` refers to, i.e. if
+  // `Type` is an alias type, we make `FromDecl` the type aias declaration.
+  // Also, don't fix the \p Type if it refers to a type alias decl in the moved
----------------
s/aias/alias


================
Comment at: unittests/change-namespace/ChangeNamespaceTests.cpp:1329
+                     "using GG = some_ns::G<int, P>;\n"
+                     "}\n"
+                     "namespace na {\n"
----------------
Add a trailing `// namespace na`. The same below.


https://reviews.llvm.org/D27801





More information about the cfe-commits mailing list