[PATCH] D27597: [DebugInfo] Restore test case for long double constants.

Paul Robinson via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Dec 13 16:50:32 PST 2016


probinson accepted this revision.
probinson added a comment.
This revision is now accepted and ready to land.

In https://reviews.llvm.org/D27597#621618, @dgross wrote:

> So would a Python equivalent of the Perl be acceptable?  I think this is an academic question -- better to explicitly test multiple triples.


There are a small number of tests that run Python scripts, but they are generally doing something really unusual (I admit I haven't gone to look, but that's my recollection).  If you can get proper coverage without Python, and it doesn't require standing on your head, people generally prefer that.  In this case, multiple RUNs with different triples will do the job, so that's preferable.

LGTM.


https://reviews.llvm.org/D27597





More information about the cfe-commits mailing list