[PATCH] D27424: Add the diagnose_if attribute to clang.

[Akira Hatanaka via Phabricator via cfe-commits]

ahatanak added inline comments.


================
Comment at: include/clang/Sema/Overload.h:754
+    unsigned NumInlineBytesUsed;
+    llvm::AlignedCharArray<alignof(ImplicitConversionSequence), NumInlineBytes>
         InlineSpace;
----------------
I guess you could use "void *" instead of ImplicitConversionSequence for the alignment to make it clear that this has the alignment of a pointer type (or the larger of alignof(ImplicitConversionSequence) and alignof(DiagnoseIfAttr *))?


https://reviews.llvm.org/D27424