[PATCH] D27621: [clang-tidy] check to find declarations declaring more than one name

Firat Kasmis via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Dec 13 05:25:21 PST 2016


firolino marked an inline comment as done.
firolino added inline comments.


================
Comment at: clang-tidy/readability/OneNamePerDeclarationCheck.cpp:154
+  if (const auto *MemberPointerT = Type->getAs<MemberPointerType>()) {
+    auto Pos = UserWrittenType.find("::");
+    if (Pos != std::string::npos) { // might be hidden behind typedef etc.
----------------
malcolm.parsons wrote:
> Can this be confused by comments that contain `::`?
Yes, it does on `int /*next time I will use C::*/ S::*p = ...;`
Working on fix/different getUserWrittenType.


https://reviews.llvm.org/D27621





More information about the cfe-commits mailing list