[libcxxabi] r289513 - [libc++abi] Mark failing test on Darwin as XFAIL

Shoaib Meenai via cfe-commits cfe-commits at lists.llvm.org
Mon Dec 12 18:43:04 PST 2016


Author: smeenai
Date: Mon Dec 12 20:43:04 2016
New Revision: 289513

URL: http://llvm.org/viewvc/llvm-project?rev=289513&view=rev
Log:
[libc++abi] Mark failing test on Darwin as XFAIL

The macOS thread-local variable finalizer routines do not handle the
case where a termination function registers another termination function
correctly, causing this test to fail. I've filed a radar for this;
mark the test XFAIL in the meantime. See [1] for more details.

[1] http://lists.llvm.org/pipermail/cfe-dev/2016-November/051376.html

Differential Revision: https://reviews.llvm.org/D27434

Modified:
    libcxxabi/trunk/test/thread_local_destruction_order.pass.cpp

Modified: libcxxabi/trunk/test/thread_local_destruction_order.pass.cpp
URL: http://llvm.org/viewvc/llvm-project/libcxxabi/trunk/test/thread_local_destruction_order.pass.cpp?rev=289513&r1=289512&r2=289513&view=diff
==============================================================================
--- libcxxabi/trunk/test/thread_local_destruction_order.pass.cpp (original)
+++ libcxxabi/trunk/test/thread_local_destruction_order.pass.cpp Mon Dec 12 20:43:04 2016
@@ -7,6 +7,10 @@
 //
 //===----------------------------------------------------------------------===//
 
+// Darwin TLV finalization routines fail when creating a thread-local variable
+// in the destructor for another thread-local variable:
+// http://lists.llvm.org/pipermail/cfe-dev/2016-November/051376.html
+// XFAIL: darwin
 // UNSUPPORTED: c++98, c++03
 // UNSUPPORTED: libcxxabi-no-threads
 




More information about the cfe-commits mailing list