[PATCH] D27575: [libcxxabi] Introduce an externally threaded libc++abi variant (take-2)

[Eric Fiselier via Phabricator via cfe-commits]

EricWF added a comment.

This LGTM. I'll approve after the inline comments are addressed.



================
Comment at: CMakeLists.txt:121
 option(LIBCXXABI_HAS_PTHREAD_API "Ignore auto-detection and force use of pthread API" OFF)
+option(LIBCXXABI_HAS_EXTERNAL_THREAD_API
+  "Build libc++abi with an externalized threading API.
----------------
Maybe use a dependent option that sets it to the value of `LIBCXX_ENABLE_THREADS` when it is defined?


================
Comment at: src/fallback_malloc.cpp:37
 class mutexor {
 public:
----------------
Can't we replace this class with `std::mutex` directly?


================
Comment at: test/test_exception_storage.pass.cpp:42
 size_t                 thread_globals [ NUMTHREADS ] = { 0 };
-__libcxxabi_thread_t   threads        [ NUMTHREADS ];
+std::__libcpp_thread_t   threads        [ NUMTHREADS ];
 #endif
----------------
What happened to the initializer?


https://reviews.llvm.org/D27575