[PATCH] D27576: [libcxx] libc++ changes necessary for the externally threaded libcxxabi variant

[Eric Fiselier via Phabricator via cfe-commits]

EricWF added a comment.

This bit LGTM.



================
Comment at: include/__threading_support:193
+// Execute once
+int __libcpp_execute_once(__libcpp_exec_once_flag *flag,
+                          void (*init_routine)(void)) {
----------------
These should have `inline`. In fact all of the functions in this header must be declared inline but have not been.


================
Comment at: test/libcxx/test/config.py:605
+        if self.get_lit_bool('cxx_ext_threads', default=False):
+            self.cxx.link_flags += ['-lcxx_external_threads']
         self.target_info.add_cxx_link_flags(self.cxx.link_flags)
----------------
I would rather use `libc++external_threads` since it uses the same prefix as `-lc++` and `-lc++experimental`


https://reviews.llvm.org/D27576