[PATCH] D27270: [libcxx] [test] Fix MSVC x64 warning C4267 "conversion from 'size_t' to 'int' [or 'unsigned int'], possible loss of data", part 4/4.

Eric Fiselier via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sun Dec 11 13:38:46 PST 2016


EricWF requested changes to this revision.
EricWF added a comment.
This revision now requires changes to proceed.

Actually I've changed my mind on this patch. While attempting to clean up `-Wconversion` errors in libc++ I found many of them were caused by these custom allocators providing a custom 32 bit size type. Since users are free to do this AFAIK it seems like we should keep these tests for it.

@STL_MSFT Does that make sense?


https://reviews.llvm.org/D27270





More information about the cfe-commits mailing list