[PATCH] D26623: [libcxx] [test] Swapping non-equal non-POCS allocators is UB.

[Eric Fiselier via Phabricator via cfe-commits]

EricWF added a comment.

I hope you don't mind but I committed by own version of this change as r289358. I was concerned about testing that the container didn't actually perform a swap, so I modified test_allocator to take an "id" parameter that does not participate in equality. I then changed the tests to check that the "id" was unchanged after the swap.

Once confirming that r289358 fixes your issues could you please close this review?


https://reviews.llvm.org/D26623