[PATCH] D27429: [Chrono][Darwin] On Darwin use CLOCK_UPTIME_RAW instead of CLOCK_MONOTONIC

Eric Fiselier via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sun Dec 11 13:38:44 PST 2016


EricWF added a comment.

Howard Thank you for your excellent analysis. Although I still don't think that `CLOCK_UPTIME_RAW` meets the requirements of `steady_clock` but I would rather relax the standard here than provide a poor implementation.

In https://reviews.llvm.org/D27429#618998, @howard.hinnant wrote:

> I feel strongly enough about this that I would like to see a static_assert that the CLOCK_MONOTONIC is never accidentally chosen by the preprocessor when targeting macOS, or iOS.


I agree. This patch LGTM after ensuring that CLOCK_MONOTONIC is never selected on Apple platforms.


https://reviews.llvm.org/D27429





More information about the cfe-commits mailing list