[PATCH] D26768: [analyzer] Improve VirtualCallChecker diagnostics and move to optin package.

[Malcolm Parsons via Phabricator via cfe-commits]

malcolm.parsons added a comment.

In https://reviews.llvm.org/D26768#618651, @dcoughlin wrote:

> The definite false positives were cases where the programmer seemed aware of the semantics of virtual calls during construction/destruction and had each subclass explicitly call its own version of the virtual method in question.


How is this avoiding the check for a qualifier on the call?

  if (CME->getQualifier())
    callIsNonVirtual = true;

> The likely false positives were cases where there was no subclass of the constructed class that overrode the method in question.

I'd like to be told about these so that the class can be marked final.


Repository:
  rL LLVM

https://reviews.llvm.org/D26768