[PATCH] D27544: [libcxx] [test] Fix MSVC warning C4244 "conversion from 'X' to 'Y', possible loss of data", part 7/7.

Stephan T. Lavavej via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Dec 8 12:34:24 PST 2016


STL_MSFT marked an inline comment as done.
STL_MSFT added inline comments.


================
Comment at: test/std/re/re.traits/value.pass.cpp:119
         }
         for (int c = 'g'; c < 0xFFFF; ++c)
         {
----------------
EricWF wrote:
> Can't we just make `c` a `wchar_t` like above?
Yes (because the bound is exclusive). It would be problematic for signed 16-bit wchar_t, but I don't think anyone's crazy enough to have that (MSVC is always unsigned 16-bit). I'll make this change.


https://reviews.llvm.org/D27544





More information about the cfe-commits mailing list