[PATCH] D27549: [DebugInfo] Add support for __fp16, float, and double constants.

[Paul Robinson via Phabricator via cfe-commits]

probinson accepted this revision.
probinson added a reviewer: probinson.
probinson added a comment.
This revision is now accepted and ready to land.

LGTM.



================
Comment at: lib/CodeGen/CGDebugInfo.cpp:3765
+    InitExpr =
+        DBuilder.createConstantValueExpression(Init.getFloat().bitcastToAPInt().getZExtValue());
   GV.reset(DBuilder.createGlobalVariable(
----------------
dgross wrote:
> probinson wrote:
> > This line exceeds 80 columns.  clang-format is your friend.
> Done.  Is clang-format mentioned in any of the documentation that describes the development process?  I might have missed it (not that that's an excuse for a needless violation of the coding guidelines).
I would have thought the coding guidelines would mention clang-format, but I'm not finding it there (or in the stuff about submitting a patch).


https://reviews.llvm.org/D27549