[PATCH] D27529: Correct Vectorcall Register passing and HVA Behavior

Erich Keane via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Dec 7 12:49:19 PST 2016


erichkeane added inline comments.


================
Comment at: lib/CodeGen/TargetInfo.cpp:1688
+    for (auto &I : FI.arguments()) {
+      if(Count < 6)
+        I.info = reclassifyHvaArgType(I.type, State, I.info);
----------------
majnemer wrote:
> erichkeane wrote:
> > majnemer wrote:
> > > Formatting.
> > I don't see what you mean?  This area went through clang-format?  What did I miss?
> Your code has "if(Count < 6)", I'm incredibly surprised that clang-format would format your code like this. There should be a space after the if and before the left-parenthesis.
Ah, thanks!  I do go through my patches and 'ctrl-K' for clang-format, so I don't know if I missed this section or what, but I've fixed it as a part of the other fixes here, and the re-clang-formatting took care of it.  Thanks for the clarification!


https://reviews.llvm.org/D27529





More information about the cfe-commits mailing list