[PATCH] D15994: Allow for unfinished #if blocks in preambles.

Erik Verbruggen via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Dec 7 06:59:21 PST 2016


erikjv marked 7 inline comments as done.
erikjv added inline comments.


================
Comment at: lib/Serialization/ASTReader.cpp:2816
+        }
+        PP.setReplayablePreambleConditionalStack(ConditionalStack);
+      }
----------------
rsmith wrote:
> Why can't we set the conditional stack on the `PPLexer` directly from here? (Why do we need to store it separately?)
Because there is no PPLexer yet. The deserialization is kicked off by ASTUnit::CodeComplete in Act->BeginSourceFile, while the lexer is created in Act->Execute.


https://reviews.llvm.org/D15994





More information about the cfe-commits mailing list