[PATCH] D27438: clang-format-vsix: add a date stamp to the VSIX version number to ensure upgradability

[Hans Wennborg via Phabricator via cfe-commits]

hans added a comment.

In https://reviews.llvm.org/D27438#614223, @amaiorano wrote:

> In https://reviews.llvm.org/D27438#614219, @hans wrote:
>
> > When building the snapshots and releases, I usually put the SVN revision number in there to avoid this same problem: http://llvm-cs.pcc.me.uk/utils/release/build_llvm_package.bat#25
>
>
> Ah, right, I was wondering how that worked. Well, if you don't think it's necessary, we don't have to do it. I didn't realize we had this script to build the official VSIX. Do you think you'd switch to using this method? Or would you prefer that the official releases be bound to the SVN rev number?


I'd prefer to keep the official releases on the SVN rev.

>> Your patch seems like a good default though. Should we put the hour and minute in there as well, in case one builds multiple versions the same day?
> 
> If you still want this change, I can definitely add the hour and minute. Let me know!

Yes, I think this is still a worthwhile change. Let's add the hour and minute and get it landed.


https://reviews.llvm.org/D27438