[PATCH] D26949: [libc++abi] Clean up visibility

[Saleem Abdulrasool via Phabricator via cfe-commits]

compnerd added a comment.

I really like the clean up this does.  It removes the unnecessary usage of the GCC pragmas and cleans up the definitions by using the headers more properly.



================
Comment at: src/abort_message.h:19
 
-__attribute__((visibility("hidden"), noreturn))
+_LIBCXXABI_HIDDEN __attribute__((noreturn))
        void abort_message(const char* format, ...) 
----------------
Please clang-format this declaration.


================
Comment at: src/private_typeinfo.cpp:61
 
-#pragma GCC visibility push(hidden)
-
-inline
+static inline
 bool
----------------
I think that if you are making this static inline, we should hoist this out into a standalone helper outside of the `__cxxabiv1` namespace.


https://reviews.llvm.org/D26949