[PATCH] D27409: [analyzer] RetainCountChecker: The callback in dispatch_data_create() doesn't free the return symbol.

Devin Coughlin via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Dec 5 09:50:54 PST 2016


dcoughlin added a comment.

Looks good to me!

To ease the future maintenance burden I would suggest moving the test into 'retain-release-arc.m' unless it really needs to be in its own separate file.



================
Comment at: test/Analysis/dispatch-data-leak.m:59
+#endif
+}
----------------
I think it would also be good to also add tests showing that we don't warn when the object is properly released. It would be good to test both ObjC -release (under MRR) and the `dispatch_release()` macro (under MRR and ARC).



https://reviews.llvm.org/D27409





More information about the cfe-commits mailing list